RFR(S): 8209162: Page size selection does not always select optimal page size

Ivan Walulya ivan.walulya at oracle.com
Tue Apr 21 17:48:54 UTC 2020


Please find new webrev

https://cr.openjdk.java.net/~iwalulya/8209162/02/

//Ivan

> On 21 Apr 2020, at 17:11, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On 21.04.20 14:59, Stefan Johansson wrote:
>> On 2020-04-21 14:44, Thomas Schatzl wrote:
>>> Hi,
>>> 
>>> On 21.04.20 14:28, Stefan Johansson wrote:
>>>> 
>>>> 
>>>> On 2020-04-21 13:22, Thomas Schatzl wrote:
>>>>> Hi,
> [...]
>>> 
>>> Then again, this is parallel gc we are talking about which you likely want to run with -Xms==-Xmx.
>>> 
>>> The "4" and "8" constants in the code are "random" numbers.
>> Yeah, the scenarios where the 8 help feels very limited and constructed. I would argue that a 1GB granularity would be a bit much even if the heap is 10g.
>> In cases where 1g pages are configured I would imagine that the heap sizes used are a lot bigger than this. Kind of like for 2mb page, if it works sub-optimal for 10mb heaps, I'm fine with that.
>> So are you ok skipping the 8 and just going for not as random 4?
> 
> That's fine with me. We can change it again.
> 
> Thomas




More information about the hotspot-gc-dev mailing list