[15] RFR 8243200: Shenandoah: Allow concurrent nmethod iteration

Roman Kennke rkennke at redhat.com
Wed Apr 22 16:28:40 UTC 2020


It looks good to me.

Roman

> Hi,
> 
>>
>> I just realize that this are chances to double free old table, so this
>> patch needs additional work. I would like to withdraw this RFR for now.
> 
> Abstracting the list for holding Shenandoah NMethod data into a class
> and reference counting the list.
> 
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8243200/webrev.01/
> 
> Test:
>   hotspot_gc_shenandoah
> 
> Thanks,
> 
> -Zhengyu
> 
>>
>> -Zhengyu
>>
>> On 4/21/20 3:46 AM, Aleksey Shipilev wrote:
>>> On 4/20/20 10:27 PM, Zhengyu Gu wrote:
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8243200
>>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8243200/webrev.00/
>>>
>>> Our code style does not allow spaces before postfix operators:
>>>   471   _itr_cnt ++;
>>> ...
>>>   478   _itr_cnt --;
>>>
>>> Otherwise looks fine. No need for another webrev.
>>>
> 




More information about the hotspot-gc-dev mailing list