RFR: 8241153: Refactor HeapRegionManager::find_unavailable_from_idx to simplify expand_at

[stefan.johansson at oracle.com]

Thanks for the reviews,

I've updated per your suggestions and will push soon.

Thanks,
Stefan

On 2020-04-23 19:55, sangheon.kim at oracle.com wrote:
> Hi Stefan,
> 
> On 4/23/20 6:59 AM, Thomas Schatzl wrote:
>> Hi,
>>
>> On 21.04.20 10:49, Stefan Johansson wrote:
>>> Hi,
>>>
>>> Please review this enhancement to simplify the expand code in G1.
>>>
>>> Webrev: http://cr.openjdk.java.net/~sjohanss/8241153/00/
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8241153
>>>
>>> Summary:
>>> Use the bitmap search functions to find candidates in 
>>> find_unavailable_from_idx and return a range to expand.
>>>
>>> Testing:
>>> Mach5 tier1-4
>>
>>  - the parameterless constructor for HeapRegionRange can be deleted, 
>> it's unused.
>>
>> No need for a re-review for this change.
> +1
> 
> Nice in general!
> 
> In addition, if you are interested:
> 1) Add 'const' at 3 getters at HeapRegionBase class.
> 2) Copyright year update for both files.
> 
> I don't need a new webrev for these changes.
> 
> Thanks,
> Sangheon
> 
> 
>>
>> Looks good.
>>
>> Thomas
>