RFR(T) : 8243942 : use SkippedException in gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA.java test

Kim Barrett kim.barrett at oracle.com
Tue Apr 28 05:45:46 UTC 2020


> On Apr 28, 2020, at 12:02 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev//8243942/webrev.00
>> 3 lines changed: 3 ins; 0 del; 0 mod; 
> 
> Hi all,
> 
> could you please review this trivial _effectively_ one-liner which updates TestSmallInitialHeapWithLargePageAndNUMA.java test to use SkippedException?
> from JBS:
>> all the checks of gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA.java test are done iff both NUMA and HugeTLB are supported, otherwise the test just exits w/o any checks performed. using SkippedException will help us to see when this test was actually run.
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8243942/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8243942
> 
> Thanks,
> -- Igor

Looks good, and trivial.




More information about the hotspot-gc-dev mailing list