RFR: 8216557 Aarch64: Add support for Concurrent Class Unloading

Ningsheng Jian ningsheng.jian at arm.com
Wed Apr 29 06:59:18 UTC 2020


On 4/28/20 7:28 PM, Stuart Monteith wrote:
> On 28/04/2020 06:26, Ningsheng Jian wrote:
>> Hi Stuart,
>>
>> On 4/28/20 12:34 AM, Stuart Monteith wrote:
>>> Thanks Erik, Per, Andrew,
>>>      I've fixed up the testcase and retested.
>>>
>>> Uploaded here:
>>>
>>>      http://cr.openjdk.java.net/~smonteith/8216557/webrev.2/
>>>
>>> Would someone be able to submit this for me?
>>>
>>
>> I submitted a build job before pushing your code, but it failed to build with minimal variant configure. Here's error
>> message:
>>
>> ./src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp: In static member function 'static AdapterHandlerEntry*
>> SharedRuntime::generate_i2c2i_adapters(MacroAssembler*, int, int, const BasicType*, const VMRegPair*,
>> AdapterFingerPrint*)':
>>
>> ./src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:736:5: error: invalid use of incomplete type 'class
>> BarrierSetAssembler'
>>
>>     bs->c2i_entry_barrier(masm);
>>
>> I think you need to include barrierSetAssembler.hpp in sharedRuntime_aarch64.cpp?
>>
>> Thanks,
>> Ningsheng
> 
> Thanks for that Ningsheng - I've made some changes, and built with minimal.
> 
> The revised patch:
> 
>   http://cr.openjdk.java.net/~smonteith/8216557/webrev.3/
> 

Looks good and pushed.

Thanks,
Ningsheng




More information about the hotspot-gc-dev mailing list