[15] RFR 8241793: Shenandoah: Enable concurrent class unloading for aarch64
Stuart Monteith
stuart.monteith at arm.com
Thu Apr 30 15:55:27 UTC 2020
On 30/04/2020 15:41, Zhengyu Gu wrote:
> Hi Stuart,
>
> Thanks for the review.
>>>>
>>> That looks good to me. I presume you created "TestGCBasherDeoptWithShenandoah.java" because you are sweeping
>>> across a
>>> number of different modes, and not just picking up on an old version of the ZGC patch? Otherwise, you might want to do
>>> what I did and add some clauses to TestGCBasherWithShenandoah like I did on Z?
>
> I missed your changes on the test.
>
> Updated:
>
> http://cr.openjdk.java.net/~zgu/JDK-8241793/webrev.01/
>
> -Zhengyu
>
>
>>>
>>> BR,
>>> Stuart
>>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you
>>> are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other
>>> person, use it for any purpose, or store or copy the information in any medium. Thank you.
>>>
>>
>
Hi Zhengyu, that looks good to me.
Is it necessary for there to be so many clauses for testing this in Shenandoah? I'm wondering whether the different
modes are likely to be worthwhile for this testing, given the increase in run time it would add.
BR,
Stuart
More information about the hotspot-gc-dev
mailing list