RFR: 8257230: assert(InitialHeapSize >= MinHeapSize) failed: Ergonomics decided on incompatible initial and minimum heap sizes [v2]

[Jie Fu]

On Mon, 30 Nov 2020 23:31:20 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> I agree that the fix is in line with the current code and I guess setting `MinHeapSize` should override `MaxVirtMemFraction` and allow us to use more than half the address space specified.
>> 
>> In this case I think I would prefer moving the the call `limit_by_allocatable_memory(reasonable_initial);` [1] to right after the calculation on line 1902 [2]. This way we would only have one line doing lower limiting and one line doing upper limiting. 
>> 
>> Makes sense? Or will that lead to some other problem?
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L1907
>> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L1902
>
>> 
>> In this case I think I would prefer moving the the call `limit_by_allocatable_memory(reasonable_initial);` [1] to right after the calculation on line 1902 [2]. This way we would only have one line doing lower limiting and one line doing upper limiting.
>> 
> 
> Good suggestion!
> 
> Will test it soon.
> Thanks.

No regression.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1492