RFR: 8254699: Suboptimal PreTouchParallelChunkSize defaults and limits
Thomas Schatzl
tschatzl at openjdk.java.net
Tue Dec 1 11:44:54 UTC 2020
On Tue, 1 Dec 2020 11:13:18 GMT, Amit Pawar <github.com+71302734+amitdpawar at openjdk.org> wrote:
>> Looks good, but could you undo the changes in pretouchTask.cpp? These break the rule to have all gang tasks with a "Running .... with ... workers" message. Also, this message is then printed for all pretouch actions - even when resizing the heap which can be quite annoying.
>>
>> Instead, the method could use a `GCTraceTime` instance to time the method. However I do not think this is really necessary or desired - imho in this case the caller should decide on whether it wants some log output, but others may have a different opinion :)
>>
>> Since a CSR is needed for changes to product flags like this, I started one with [JDK-8257419](https://bugs.openjdk.java.net/browse/JDK-8257419). Probably also needs a release note.
>
> Thanks Thomas for your reply. Log message was changed to include the time to make it easier for testing and reviewing. If not required will revert it back. Please suggest.
>
> Thanks,
> Amit
Please remove this what looks like debug code.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1503
More information about the hotspot-gc-dev
mailing list