RFR: 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow [v4]

Jie Fu jiefu at openjdk.java.net
Wed Dec 2 04:15:58 UTC 2020


On Wed, 2 Dec 2020 03:31:53 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only run the test on 64-bit machines
>
> src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 255:
> 
>> 253: static size_t calc_init_green_zone() {
>> 254:   size_t green = G1ConcRefinementGreenZone;
>> 255:   char* name = (char*) "G1ConcRefinementGreenZone";
> 
> Change the type of name to `const char*` and eliminate the cast here and on line 258.

Amazing!
It gets compiled without the casts by just adding 'const'.

Updated. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1489



More information about the hotspot-gc-dev mailing list