RFR: 8257565: epsilonBarrierSet.hpp should not include barrierSetAssembler

Ioi Lam iklam at openjdk.java.net
Wed Dec 2 05:28:01 UTC 2020


Please review this trivial fix:

epsilonBarrierSet.hpp is included (recursively via access.hpp) by many CPP files. It unncessarily includes of barrierSetAssembler.hpp, which causes many of the native code assembler header files to be unnecessarily included by many HotSpot CPP files that do not deal with native code assembly.

Removing this one line reduced the total number of header inclusion for building HotSpot from 260096 to 258193, or about 0.8%.

-------------

Commit messages:
 - 8257565: epsilonBarrierSet.hpp should not include barrierSetAssembler

Changes: https://git.openjdk.java.net/jdk/pull/1554/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1554&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8257565
  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1554.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1554/head:pull/1554

PR: https://git.openjdk.java.net/jdk/pull/1554



More information about the hotspot-gc-dev mailing list