Integrated: 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow

Jie Fu jiefu at openjdk.java.net
Wed Dec 2 06:55:01 UTC 2020


On Sat, 28 Nov 2020 08:26:57 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> SIGFPE was observed by running:
> java -XX:G1ConcRefinementThresholdStep=16G -XX:G1UpdateBufferSize=1G -version
> 
> The reason is that buffers_to_cards [1] returns 0 for 'step' due to overflow.
> It would be better to add overflow check logic is it.
> 
> Testing:
>   - tier1 on Linux/x64
> 
> Thanks.
> Best regards,
> Jie
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp#L235

This pull request has now been integrated.

Changeset: f2a0988a
Author:    Jie Fu <jiefu at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/f2a0988a
Stats:     64 lines in 2 files changed: 57 ins; 0 del; 7 mod

8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow

Reviewed-by: kbarrett, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/1489



More information about the hotspot-gc-dev mailing list