RFR: 8257565: epsilonBarrierSet.hpp should not include barrierSetAssembler

Aleksey Shipilev shade at openjdk.java.net
Wed Dec 2 07:12:56 UTC 2020


On Wed, 2 Dec 2020 05:22:04 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this trivial fix:
> 
> epsilonBarrierSet.hpp is included (recursively via access.hpp) by many CPP files. It unncessarily includes of barrierSetAssembler.hpp, which causes many of the native code assembler header files to be unnecessarily included by many HotSpot CPP files that do not deal with native code assembly.
> 
> Removing this one line reduced the total number of header inclusion for building HotSpot from 260096 to 258193, or about 0.8%.

Changes requested by shade (Reviewer).

src/hotspot/share/gc/epsilon/epsilonBarrierSet.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.

Why the copyright line addition, though? It is not like Red Hat adds its copyrights for trivial changes to shared files like these.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1554



More information about the hotspot-gc-dev mailing list