RFR: 8257145: Performance regression with -XX:-ResizePLAB after JDK-8079555 [v2]

Stefan Johansson sjohanss at openjdk.java.net
Wed Dec 2 10:13:55 UTC 2020


On Wed, 2 Dec 2020 01:34:32 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

>> I think the move to use ParallelGCThreads in `g1EvacStats.cpp` is good, please also add:
>> #include "runtime/globals.hpp"
>> 
>> To not rely on other includes.
>
>> I think the move to use ParallelGCThreads in `g1EvacStats.cpp` is good, please also add:
>> 
>> ```
>> #include "runtime/globals.hpp"
>> ```
>> 
>> To not rely on other includes.
> 
> Do you mean adding `#include "runtime/globals.hpp"` to  `plab.hpp` on [Refactor the code](https://github.com/openjdk/jdk/pull/1474/commits/dd3f9b7cdca5d400c7b2296c3eee92e1c414a2bb)?

Please add it to `g1EvacStats.cpp`, the refactoring was good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1474



More information about the hotspot-gc-dev mailing list