RFR: 8257145: Performance regression with -XX:-ResizePLAB after JDK-8079555 [v2]

[Stefan Johansson]

On Wed, 2 Dec 2020 10:49:55 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

>> Please add it to `g1EvacStats.cpp`, the refactoring was good.
>
>> Please add it to `g1EvacStats.cpp`, the refactoring was good.
> 
> When I add it to g1EvacStates.cpp on [Refactor the code](https://github.com/openjdk/jdk/pull/1474/commits/dd3f9b7cdca5d400c7b2296c3eee92e1c414a2bb) , like this:
> diff --git a/src/hotspot/share/gc/g1/g1EvacStats.cpp b/src/hotspot/share/gc/g1/g1EvacStats.cpp
> index f8851b55dda..3f0f1b76cea 100644
> --- a/src/hotspot/share/gc/g1/g1EvacStats.cpp
> +++ b/src/hotspot/share/gc/g1/g1EvacStats.cpp
> @@ -27,6 +27,7 @@
>  #include "gc/shared/gcId.hpp"
>  #include "logging/log.hpp"
>  #include "memory/allocation.inline.hpp"
> +#include "runtime/globals.hpp"
> 
>  void G1EvacStats::log_plab_allocation() {
>    PLABStats::log_plab_allocation();
> 
> I still get an error in the build:
> === Output from failing command(s) repeated here ===
> * For target hotspot_variant-server_libjvm_objs_g1EvacStats.o:
> In file included from /home/hedongbo/temp/jdk/src/hotspot/share/gc/g1/g1EvacStats.hpp:28:0,
>                  from /home/hedongbo/temp/jdk/src/hotspot/share/gc/g1/g1EvacStats.cpp:26:
> 
> 
>      _desired_net_plab_sz(default_per_thread_plab_size * ParallelGCThreads),
>                                                          ^~~~~~~~~~~~~~~~~
> At global scope:
> cc1plus: error: unrecognized command line option '-Wno-cast-function-type' [-Werror]
> but it's OK to add it to `plab.hpp`. So, I do not know whether I have understood your meaning correctly. Thank you for your patient reply.

As I said:
> I think the move to use ParallelGCThreads in g1EvacStats.cpp is good...

I liked that refactoring of moving the use of `ParallelGCThreads` to G1EvacStats, I just want you to also add the include there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1474