RFR: 8257509: Strengthen requirements to call G1HeapVerifier::verify(VerifyOption)

Stefan Johansson sjohanss at openjdk.java.net
Thu Dec 3 09:31:55 UTC 2020


On Thu, 3 Dec 2020 08:52:02 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this little change to strengthen the requirements for calling G1HeapVerifier::verify(VerifyOption)?
> 
> In particular, instead of the failed attempt to abort verification if we are not at a safepoint, assert that we are at a safepoint.
> 
> Testing: tier1-5 with no failures
> 
> Thanks,
>   Thomas

Looks good. I would prefer if you remove the blank line between the asserts (line 475) before integrating.

-------------

Marked as reviewed by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1590



More information about the hotspot-gc-dev mailing list