RFR: 8257509: Strengthen requirements to call G1HeapVerifier::verify(VerifyOption) [v2]

[Albert Mingkun Yang]

On Thu, 3 Dec 2020 09:36:09 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this little change to strengthen the requirements for calling G1HeapVerifier::verify(VerifyOption)?
>> 
>> In particular, instead of the failed attempt to abort verification if we are not at a safepoint, assert that we are at a safepoint.
>> 
>> Testing: tier1-5 with no failures
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   sjohanss review, remove newline

I wonder if it's possible/beneficial to use `assert_at_safepoint_on_vm_thread` to cover two assertions here.

-------------

Marked as reviewed by ayang (Author).

PR: https://git.openjdk.java.net/jdk/pull/1590