RFR: 8257230: assert(InitialHeapSize >= MinHeapSize) failed: Ergonomics decided on incompatible initial and minimum heap sizes [v3]

[Stefan Johansson]

On Fri, 4 Dec 2020 04:09:14 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Took a closer look at the test now, some comment below.
>
> Hi @kstefanj ,
> 
> Thanks for your review.
> 
> The fix has been updated according to your comments.
> 
> I don't check the exit value because I found different platforms may return different values (Zero on MacOS, but non-zero on Linux).
> Maybe, It should return 0 on Linux too, which I think is more reasonable.
> And I'd like to file another bug to fix it in the future.
> 
> Thanks.
> Best regards,
> Jie

It should be 0 on Linux and after the addition of `@requires os.family == "linux"` it should only be run on Linux. Doing some manual runs show that the JVM can't start with an ulimit as low as in the test. If the startup in the test is not successful I don't think the test has any value, so we need to find values that make it reliable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1492