RFR: 8257230: assert(InitialHeapSize >= MinHeapSize) failed: Ergonomics decided on incompatible initial and minimum heap sizes [v3]
Stefan Johansson
sjohanss at openjdk.java.net
Fri Dec 4 10:16:18 UTC 2020
On Fri, 4 Dec 2020 09:40:16 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> It should be 0 on Linux and after the addition of `@requires os.family == "linux"` it should only be run on Linux. Doing some manual runs show that the JVM can't start with an ulimit as low as in the test. If the startup in the test is not successful I don't think the test has any value, so we need to find values that make it reliable.
>
>> It should be 0 on Linux and after the addition of `@requires os.family == "linux"` it should only be run on Linux. Doing some manual runs show that the JVM can't start with an ulimit as low as in the test. If the startup in the test is not successful I don't think the test has any value, so we need to find values that make it reliable.
>
> Hi @kstefanj ,
>
> The test is used to check whether the assert is triggered.
> Before the fix, it failed.
> After the fix, it passed.
>
> As I mentioned above, there seems to be another bug on Linux.
> It does return 0 on MacOS.
> And I also think it should return 0 on Linux.
> I'll file another bug to fix it.
>
> What do you think?
>
> Thanks.
> Best regards,
> Jie
Yes it might check that the assert doesn't trigger, but if the test is not robust enough to always manage to execute `java -version` we might start to see other failures in that test. In some sense the test is just lucky that it fails in a way that a hs_err-file is not created.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1492
More information about the hotspot-gc-dev
mailing list