[jdk16] RFR: 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region

[Stefan Johansson]

On Thu, 17 Dec 2020 11:01:33 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/hotspot/share/gc/parallel/psOldGen.cpp line 385:
>> 
>>> 383: 
>>> 384:   // ALWAYS do this last!!
>>> 385:   OrderAccess::storestore();
>> 
>> Maybe update the comment to use less caps and '!'. Instead tie back to the function comment explaining that the barrier is needed to guarantee the order in which the data structures get visible to other threads.
>
> Good idea.  Here's the revised comment:
> 
> -  // ALWAYS do this last!!
> +  // Ensure the space bounds are updated are made visible to other
> +  // threads after the other data structures have been resized.
>    OrderAccess::storestore();

The second "are" should be an "and", right? Otherwise looks great!

-------------

PR: https://git.openjdk.java.net/jdk16/pull/35