RFR[T]: 8240133: G1DirtyCardQueue destructor has useless flush
Stefan Johansson
stefan.johansson at oracle.com
Fri Mar 6 09:10:18 UTC 2020
Hi Kim,
On 2020-03-04 03:17, Kim Barrett wrote:
> Please review this trivial change to remove the useless call to flush() from
> the G1DirtyCardQueue destructor. See the CR for more details. This removes
> the need for a non-trivial destructor for that class.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8240133
>
> Webrev:
> https://cr.openjdk.java.net/~kbarrett/8240133/open.00/
Would it make sense to add an assert into the destructor to ensure no
entries were added? Or is that problematic for some reason.
If you prefer not to, I'm good with this change and you can consider it
reviewed.
Cheers,
Stefan
>
> Testing:
> mach5 tier1-5 along with changes for JDK-8239825 and JDK-8139652.
> Local (linux-x64) hotspot:tier1 with this and the proposed JDK-8239825 change.
>
More information about the hotspot-gc-dev
mailing list