RFR: 8231668: Remove ForceDynamicNumberOfGCThreads
Aleksey Shipilev
shade at redhat.com
Thu Mar 12 06:09:28 UTC 2020
On 3/12/20 2:40 AM, Aditya Mandaleeka wrote:
> RFE:
> https://bugs.openjdk.java.net/browse/JDK-8231668
>
> Webrev:
> https://cr.openjdk.java.net/~adityam/8231668/
This looks good to me.
Stylistic nits:
*) Conditions like this:
865 if (!UseDynamicNumberOfGCThreads ||
866 !FLAG_IS_DEFAULT(ConcGCThreads)) {
...can now be written like:
if (!UseDynamicNumberOfGCThreads || !FLAG_IS_DEFAULT(ConcGCThreads)) {
*) Please update copyrights to mention 2020. For example, in workerPolicy.cpp:
Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
> Note: this is my first patch since getting Author status, so please feel free to let me know if there's
> anything wrong with how I created the webrev. Other friendly folks have been doing that for me
> until now :).
Many of us use "mq" extension to stash the patches. The upside with webrevs would be that you can
add the changeset description (hg qrefresh -e) right to the patch, and then webrev would pick it up.
It would also generate the changeset itself, so sponsors would just download it and push on your behalf.
Metadata for this change is something like:
8231668: Remove ForceDynamicNumberOfGCThreads
Reviewed-by: XXX (list of reviewers from census)
Contributed-by: Aditya Mandaleeka <adityam at microsoft.com>
--
Thanks,
-Aleksey
More information about the hotspot-gc-dev
mailing list