RFR: 8240873: Shenandoah: Short-cut arraycopy barriers

Roman Kennke rkennke at redhat.com
Thu Mar 12 11:04:31 UTC 2020



On 3/12/20 9:31 AM, Aleksey Shipilev wrote:
> On 3/11/20 8:54 PM, Roman Kennke wrote:
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8240873
>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/JDK-8240873/webrev.00/
> 
> *) Wouldn't it make more sense to do acquire/release in (get|set)_update_watermark?
> 

Hmm ok. This requires making the field. I am not sure if the cast in
get_update_watermark() is ok?

> *) This bit is incorrect, should be set_update_watermark:
> 
> 2426       r->set_concurrent_iteration_safe_limit(r->bottom());

Hoops. Corrected.


http://cr.openjdk.java.net/~rkennke/JDK-8240873/webrev.02/

WDYT?





More information about the hotspot-gc-dev mailing list