RFR: 8231668: Remove ForceDynamicNumberOfGCThreads
Thomas Schatzl
thomas.schatzl at oracle.com
Thu Mar 12 13:00:51 UTC 2020
Hi,
On 12.03.20 02:40, Aditya Mandaleeka wrote:
> RFE:
> https://bugs.openjdk.java.net/browse/JDK-8231668
>
> Webrev:
> https://cr.openjdk.java.net/~adityam/8231668/
>
> This removes all the ForceDynamicNumberOfGCThreads-related code and the test cases using it.
>
> Note: this is my first patch since getting Author status, so please feel free to let me know if there's
> anything wrong with how I created the webrev. Other friendly folks have been doing that for me
> until now :).
in addition to what Aleksey said:
- a comment in TestDynamicNumberOfGCThreads refers to a non-existent
option "TraceDynamicGCThreads"
- I think that that entire test does not test a lot as it only checks
whether that log message is printed, but it does not check whether there
is actually a dynamic change in number of gc threads over time.
I think it can be removed. Feel free to file a separate CR for improving
it or creating a new one, depending on whether you remove it or not.
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list