RFR: 8241666: Enhance log messages in ReferenceProcessor

Stefan Johansson stefan.johansson at oracle.com
Thu Mar 26 19:25:37 UTC 2020


Thanks for the review guys,

On 2020-03-26 16:53, sangheon.kim at oracle.com wrote:
> Hi Stefan,
> 
> On 3/26/20 7:55 AM, Thomas Schatzl wrote:
>> Hi,
>>
>> On 26.03.20 14:07, Stefan Johansson wrote:
>>> Hi,
>>>
>>> Please review this change to improve some logging messages.
>>>
>>> Webrev: http://cr.openjdk.java.net/~sjohanss/8241666/00/
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8241666
>>>
>>> Summary
>>> The old logging messages were a bit unclear and when checking if the 
>>> tests needed to be updated I found some unused static members that I 
>>> removed.
>>>
>>> Testing
>>> Locally run GC tests and mach5 tier1 and tier2.
>>
>>   the only nit I can see is in the new log message in 
>> referenceProcessor.cpp:791:
>>
>> "Skipped phase 1 of Reference Processing: no policy to reconsider"
>>
>> I would remove the "to reconsider" part as it seems unnecessary. Feel 
>> free to ignore. No need to re-review.
> +1
I will remove the "to reconsider" part and push tomorrow unless anyone 
else comes in and object.

Cheers,
Stefan

> 
> Thanks,
> Sangheon
> 
> 
>>
>> Thomas
>>
> 



More information about the hotspot-gc-dev mailing list