[aarch64-port-dev ] RFR: 8216557 Aarch64: Add support for Concurrent Class Unloading

[Stuart Monteith]

Thanks Andrew,

I'll change that round. The code verifying the barrier would catch any change
there anyway.

On 27/03/2020 12:36, Andrew Haley wrote:
> On 3/26/20 10:42 PM, Stuart Monteith wrote:
>>
>>         BarrierSetAssembler::nmethod_entry_barrier
>>         This method emits the barrier code. In internal review it was suggested
>> the "dmb( ISHLD )" should be replaced by "membar(LoadLoad)". I've not
>> done this as the BarrierSetNMethod code checks the exact instruction
>> sequence, and I prefer to be explicit.
>
> I understand, but LoadLoad is the semantics you need, and it's more important
> to say that. The mere existence of verification code shouldn't determine
> how you express the runtime code.
>
> I'll do a thorough review later.
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.