RFR: 8240745: Implementation: JEP 377: ZGC: A Scalable Low-Latency Garbage Collector (Production)

[Per Liden]

Hi Erik,

On 3/28/20 11:54 AM, Erik Gahlin wrote:
> Hi Per,
> 
> I couldn’t see any unit tests for the JFR events. All supported events should have that.

Check, I'll look into adding that.

> 
> I also wonder about the ZStatisticsCounter event. JFR events should provide metadata (label, name, units etc) describing values. Either refactor it into well-formed events, or keep the event experimental.

Yes, we intend to keep ZStatisticsCounter and ZStatisticsSampler 
experimental at this time.

cheers,
Per

> 
> Thanks
> Erik
> 
>> On 27 Mar 2020, at 15:30, Per Liden <per.liden at oracle.com> wrote:
>>
>> Please review the patch for JEP 377: ZGC: A Scalable Low-Latency Garbage Collector (Production).
>>
>> This patch changes the UseZGC option, some of the ZGC-specific options, as well as some of the ZGC-specific JFR events from experimental to product. It also adjusts tests using ZGC to not supply -XX:+UnlockExperimentalVMOptions.
>>
>> Note that this patch builds on JDK-8241361, which as of this writing, has not yet been pushed.
>>
>> JEP: https://openjdk.java.net/jeps/377
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8240745
>> Webrev: http://cr.openjdk.java.net/~pliden/8240745/webrev.0
>>
>> Testing: Passed tier 1-7 on all platforms.
>>
>> /Per
>