RFR (S) 8241844: Shenandoah: rename ShenandoahHeapRegion::region_number

Aleksey Shipilev shade at redhat.com
Mon Mar 30 13:38:43 UTC 2020


On 3/30/20 3:26 PM, Roman Kennke wrote:
>> RFR:
>>   https://bugs.openjdk.java.net/browse/JDK-8241844
>>
>> ShenandoahHeapRegion::region_number is too verbose of the name, plus most of the code already treats
>> it as "index" in the local variable. Can rename it for consistency. I am not sure whether it should
>> be "idx" or "index".
>>
>> Candidate fix:
>>   https://cr.openjdk.java.net/~shade/8241844/webrev.01/
>>
>> Testing: hotspot_gc_shenandoah
> 
> I'd prefer index, but if it's too much trouble to rename it, then leave
> it as idx.

No bother until this is committed. Renamed to "index" like this:
  https://cr.openjdk.java.net/~shade/8241844/webrev.01/

Better?

-- 
Thanks,
-Aleksey




More information about the hotspot-gc-dev mailing list