RFR: 8241830: Simplify commit error messages in G1PageBasedVirtualSpace

[Stefan Johansson]

Hi,

On 2020-03-30 16:23, Claes Redestad wrote:
> Hi,
> 
> when committing memory for virtual space, we eagerly generate an error
> message using err_msg, which ends up malloc'ing some memory. As this is
> done for each potential heap region, this turns out to have a
> significant cost on startup when ergonomics decide we should run with
> many regions.
> 
> Since the address range information is redundant (a warning will be
> printed along with the hs_err file with similar detail), I propose
> replacing with a static error message. This aligns with other call
> sites. For unrecoverable mmap failures, the message will be ignored and
> replaced by "committing reserved memory", meaning the extra information
> is unlikely to actually manifest.
> 
> Webrev: http://cr.openjdk.java.net/~redestad/8241830/open.00/
This looks good to me, thanks for fixing.

StefanJ

> Bug:    https://bugs.openjdk.java.net/browse/JDK-8241830
> 
> Thanks!
> 
> /Claes