RFR: 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes

Kim Barrett kim.barrett at oracle.com
Thu May 14 06:47:45 UTC 2020


> On May 13, 2020, at 8:38 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On May 13, 2020, at 9:56 AM, Ivan Walulya <ivan.walulya at oracle.com> wrote:
>> 
>> Thanks Kim,
>> 
>> Suggested modifications have been made in a new webrev:
>> 
>> https://cr.openjdk.java.net/~iwalulya/8244752/01/
> 
> Looks good.

I forgot one comment.

------------------------------------------------------------------------------
src/hotspot/os/linux/os_linux.cpp
3798   if (dir_is_empty(sys_hugepages)) {
3799     return false;
3800   }

There doesn't seem much point to this.  dir_is_empty just opens the
directory and looks to see if there's anything interesting.

------------------------------------------------------------------------------

I don’t need a new webrev if you delete that.




More information about the hotspot-gc-dev mailing list