[15] RFR 8245823: Shenandoah: inline/optimize ShenandoahEvacOOMScope
Aleksey Shipilev
shade at redhat.com
Tue May 26 16:33:05 UTC 2020
On 5/26/20 5:36 PM, Zhengyu Gu wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8245823
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8245823/webrev.00/index.html
Hm! I actually thought we optimized ShenandoahHeap::heap() enough not to matter [1]. Reverting
heap() cache would seem to ditch some of these overloads:
131 inline ShenandoahEvacOOMScope();
132 inline ShenandoahEvacOOMScope(Thread* t);
133 inline ShenandoahEvacOOMScope(ShenandoahHeap* heap);
134 inline ShenandoahEvacOOMScope(ShenandoahHeap* heap, Thread* t);
135 inline ~ShenandoahEvacOOMScope();
Thread:current() seems fine to pass, where available, and store locally.
--
Thanks,
-Aleksey
[1] https://bugs.openjdk.java.net/browse/JDK-8241743
More information about the hotspot-gc-dev
mailing list