RFR: 8252103: Parallel heap inspection for ParallelScavengeHeap [v14]

Stefan Johansson sjohanss at openjdk.java.net
Wed Nov 4 11:14:56 UTC 2020


On Wed, 4 Nov 2020 10:51:08 GMT, Lin Zang <lzang at openjdk.org> wrote:

>> - Parallel heap iteration support for PSS
>> - JBS:  https://bugs.openjdk.java.net/browse/JDK-8252103
>
> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   improve readability and use SIZE_MAX for InvalidIndex

src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp line 560:

> 558:   size_t claim_and_get_block() {
> 559:     size_t block_index;
> 560:     block_index = Atomic::fetch_and_add(&_claimed_index, (size_t)1);

Instead of the cast please use 1u
Suggestion:

    block_index = Atomic::fetch_and_add(&_claimed_index, 1u);

-------------

PR: https://git.openjdk.java.net/jdk/pull/25



More information about the hotspot-gc-dev mailing list