RFR: 8256155: 2M large pages for code when LargePageSizeInBytes is set to 1G for heap [v2]

Marcus G K Williams github.com+168222+mgkwill at openjdk.java.net
Thu Nov 19 03:06:09 UTC 2020


On Wed, 18 Nov 2020 19:14:08 GMT, Marcus G K Williams <github.com+168222+mgkwill at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 3970:
>> 
>>> 3968:                                             char* req_addr, bool exec) {
>>> 3969:   size_t large_page_size;
>>> 3970:   large_page_size = os::select_large_page_size(bytes, exec);
>> 
>> The "os" is shared and platform generic. Please don't add anything there unless you write (and test as much as possible) the different platforms. I do not see why this API should even be exported from this unit.
>
> Understood. Will move from src/hotspot/share/runtime/os.hpp to src/hotspot/os/linux/os_linux.hpp .

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1153



More information about the hotspot-gc-dev mailing list