RFR: 8254999: Move G1RemSetSamplingTask to more appropriate location [v3]

Albert Mingkun Yang ayang at openjdk.java.net
Tue Nov 24 12:44:57 UTC 2020


On Tue, 24 Nov 2020 12:29:11 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1RemSet.cpp line 499:
>> 
>>> 497: G1RemSet::~G1RemSet() {
>>> 498:   delete _scan_state;
>>> 499:   if (_sampling_task != NULL) {
>> 
>> Could you add a comment to explain when `_sampling_task` would be null?
>
> Actually the check can be removed because the operator implementation handles NULL (by ignoring it).

Even better. Thanks for the suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1395



More information about the hotspot-gc-dev mailing list