RFR: 8257162: Initialize ThreadLocalAllocBuffer members

Aleksey Shipilev shade at openjdk.java.net
Thu Nov 26 13:50:00 UTC 2020


On Thu, 26 Nov 2020 13:34:26 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this change that adds initialization for all ThreadLocalAllocBuffer members so that when inspecting threads' TLABs the values are not random too?
> 
> Testing: tier1,tier2
> 
> Thanks,
>   Thomas

Looks good to me.

src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp line 58:

> 56:   _allocation_fraction(TLABAllocationWeight) {
> 57: 
> 58:   // do nothing.  tlabs must be inited by initialize() calls

Wording: `Do nothing. TLABs must be initialized by initialize() calls.`

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1458



More information about the hotspot-gc-dev mailing list