RFR: 8257162: Initialize ThreadLocalAllocBuffer members [v3]

[Stefan Johansson]

On Thu, 26 Nov 2020 14:33:09 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that adds initialization for all ThreadLocalAllocBuffer members so that when inspecting threads' TLABs the values are not random too?
>> 
>> Testing: tier1,tier2
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ayang review. Remove old constructor.

Looks good, just this comment on the comment that you can skip if you don't agree.

src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp line 59:

> 57: 
> 58:   // do nothing. TLABs must be inited by initialize() calls
> 59: }

Any reason for the extra blank line here? I would also use a capital D in "Do nothing".

-------------

Marked as reviewed by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1458