RFR: 8255001: Move G1PeriodicGCTask to its own file [v2]

Stefan Johansson sjohanss at openjdk.java.net
Fri Nov 27 12:02:15 UTC 2020


On Fri, 27 Nov 2020 09:41:27 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge branch 'master' into 8255001-move-periodic-gc-task
>>  - 8255001: Move G1PeriodicGCTask to its own file
>
> src/hotspot/share/gc/g1/g1PeriodicGCTask.hpp line 31:
> 
>> 29: #include "utilities/globalDefinitions.hpp"
>> 30: #include "utilities/ticks.hpp"
>> 31: 
> 
> Only the g1ServiceThread include seems to be required here. The others can be moved to the cpp file.

Good catch, move the `#include "utilities/globalDefinitions.hpp"` to the cpp file, `tick.hpp` was not needed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1471



More information about the hotspot-gc-dev mailing list