RFR: 8255001: Move G1PeriodicGCTask to its own file [v4]

Leo Korinth lkorinth at openjdk.java.net
Mon Nov 30 13:55:02 UTC 2020


On Fri, 27 Nov 2020 12:06:04 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> After making the service thread task based it is now possible to move the tasks out of `g1ServiceThread.cpp`. The periodic task is moved to its own files and the initialization and registration with the service thread is done while initializing `G1CollectedHeap`.
>> 
>> No functionality is changed for the task, but it has been split up into a header and a source file. 
>> 
>> **Testing**
>> tier 1-2 + manual testing setting `G1PeriodicGCInterval` through `jcmd`.
>
> Stefan Johansson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge branch 'master' into 8255001-move-periodic-gc-task
>  - Thomas review
>  - Merge branch 'master' into 8255001-move-periodic-gc-task
>  - 8255001: Move G1PeriodicGCTask to its own file

Looks good to me.

-------------

Marked as reviewed by lkorinth (Committer).

PR: https://git.openjdk.java.net/jdk/pull/1471



More information about the hotspot-gc-dev mailing list