RFR: 8253938: ZGC: Clean up argument names after JDK-8253030
Per Liden
pliden at openjdk.java.net
Fri Oct 2 16:18:39 UTC 2020
On Fri, 2 Oct 2020 15:47:38 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Lgtm and trivial to me.
>
> Maybe it makes sense to use microseconds in the destructor of `ZMarkTimeout` as well, now that all times in this file
> are converting from ms to us.
> log_debug(gc, marking)("Mark With Timeout (%s): %s, " UINT64_FORMAT " oops, %.3fms",
> ZThread::name(), _expired ? "Expired" : "Completed",
> _check_count, TimeHelper::counter_to_millis(duration.value()));
@albertnetymk We print all times in milliseconds (with three decimals) in ZGC, and I think we should continue to do
that here too.
-------------
PR: https://git.openjdk.java.net/jdk/pull/483
More information about the hotspot-gc-dev
mailing list