RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v9]

[Richard Reingruber]

On Sat, 3 Oct 2020 09:45:29 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Let us ship this. Thanks for all your great work, great presentations and for doing all the tedious fixes.
>
>> Let us ship this. Thanks for all your great work, great presentations and for doing all the tedious fixes.
>> 
>> /Leo
> 
> Great, thank you too for your thorough review work!

Hi Thomas, I'm currently working on a review. There are still many sections where you separate 2 lines of code with an
empty line. My review is filling up with comments on that. I'm afraid this will hide the few other/real points
therefore I'll stop annotating empty lines. Instead I'd like to ask you to look over each file changed (you cannot see
it always in the diff on Github) and remove as many empty lines as possible to better match the existing style.
`virtualSpaceNode.cpp` would be a good file to start with (e.g. lines 106 and following, 280 and following). You could
also grep for { followed by an empty line and } proceeded by an empty line. Thanks, Richard.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336