RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v8]

[Thomas Stuefe]

On Mon, 5 Oct 2020 09:25:16 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> Hi Thomas,
> 
> I've viewed 41/166 files. I'm sending you my findings so far so we can work concurrently. Also I'm curious how it goes
> sending a partial review and then continuing.

You just finish one Review (with "comment" or "reqzest changes"), and later start a new Review. Only downside is that
you get multiple mails in the ML, but I think that is okay here.

> 
> Probably I won't manage to review all the tests but I do hope I get to read all files of the implementation. Working on
> it now...

Totally fine. The implementation in hotspot is the important part.

> Btw: I couldn't find out how to navigate from one of my comments to the line of code. At least, when I click on the
> file name, this brings me to a view of the patch at the version I commented on so the line numbers are correct even if
> they changed in the head revision of the pr.

The line of code a comment applies to is the lowest in the code excerpt shown atop of the comment. Unless the comment
applied to multiple lines, then it shows (eg "Comment on lines +105 to +110").

> 
> Cheers, Richard.

Thanks, Tomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/336