RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v9]

[Thomas Stuefe]

On Sat, 3 Oct 2020 08:02:25 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Misc. Review feedback
>>  - Move ClassLoaderMetaspace to own include and correct includes
>
> src/hotspot/share/memory/metaspace/binList.hpp line 141:
> 
>> 139:       assert(_blocks[i2] != NULL, "mask mismatch");
>> 140:       return i2;
>> 141:     }
> 
> There would be `count_leading_zeros()`.
> If I'm not mistaken, it is _trailing_ zeros that are counted. So you could use
> [count_trailing_zeros()](https://github.com/openjdk/jdk/blob/d296708ca66ab15e31a05f963a5e162a3e3f07f9/src/hotspot/share/utilities/count_trailing_zeros.hpp#L31)

Right. I'll just remove the comment.

> src/hotspot/share/memory/metaspace.hpp line 136:
> 
>> 134:
>> 135:   static void report_metadata_oome(ClassLoaderData* loader_data, size_t word_size,
>> 136:                                    MetaspaceObj::Type type, Metaspace::MetadataType mdtype, TRAPS);
> 
> The change is not necessary.
> You havn't changed the definition either (metaspace.cpp:830, link does not seem to work).
> https://github.com/openjdk/jdk/pull/336/files#diff-07bf2be25d84c251ed6107aab47fd009R830

The enums moved around a lot until ending up at the exact place as before the patch. I'll remove the scope.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336