RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v9]

[Thomas Stuefe]

On Sat, 3 Oct 2020 12:06:01 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Misc. Review feedback
>>  - Move ClassLoaderMetaspace to own include and correct includes
>
> src/hotspot/share/memory/metaspace/blockTree.hpp line 193:
> 
>> 191:         n2 = succ;
>> 192:         succ = succ->_parent;
>> 193:       }
> 
> You could inline just the then-block into `remove_node_from_tree()` which is the only caller of `successor()`

I rather leave it, I find it clearer that way.

> src/hotspot/share/memory/metaspace/blockTree.hpp line 219:
> 
>> 217:
>> 218:   // Given a node n and an insertion point, insert n under insertion point.
>> 219:   void insert(Node* insertion_point, Node* n) {
> 
> Could be static

True.

> src/hotspot/share/memory/classLoaderMetaspace.cpp line 160:
> 
>> 158:   DEBUG_ONLY(InternalStats::inc_num_deallocs();)
>> 159:
>> 160: }
> 
> Too many empty lines if you're asking me ;)

Okay will fix.

> src/hotspot/share/memory/metaspace/blockTree.hpp line 174:
> 
>> 172:     return pred;
>> 173:   }
>> 174:
> 
> Looks like `predecessor()` is not used.

Will remove.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336