RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v11]

Richard Reingruber rrich at openjdk.java.net
Tue Oct 6 13:57:16 UTC 2020


On Tue, 6 Oct 2020 12:19:25 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/share/memory/metaspace/metachunk.hpp line 154:
>> 
>>> 152:   // This means only read or modify these members under expand lock protection.
>>> 153:   Metachunk* _prev_in_vs;
>>> 154:   Metachunk* _next_in_vs;
>> 
>> I think the field `_next_in_vs` could be eliminated. The next chunk begins at the `end()` of this chunk.
>
> The idea is good, but at the moment _next_in_vs==NULL marks the last chunk within one root chunk area, and is used e.g.
> as loop stop. I would have to make Metachunk aware of the root chunk it lives in, which I rather avoid.

Ok.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336



More information about the hotspot-gc-dev mailing list