RFR: 8254285: G1: Remove "What is this about" comment in G1CollectedHeap.cpp

Thomas Schatzl tschatzl at openjdk.java.net
Fri Oct 9 10:00:21 UTC 2020


On Fri, 9 Oct 2020 09:54:22 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I get quick reviews for this imho trivial change that removes some strange comment leftover from initial G1 import
>>   reading:
>> 
>>    // FIXME: what is this about?
>>   // I'm ignoring the "fill_newgen()" call if "alloc_event_enabled"
>>   // is set.
>> 
>> None of the referenced identifiers are in any kind of recent code base (looking back to some pre-g1 7u changes). In its
>> current context it does not make sense either and apparently whatever omission the comment suggests has not hurt G1 for
>> years.  Testing: local compilation
>> 
>> Thanks,
>>   Thomas
>
> Looks good.

Thanks @shipilev @kstefanj for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/573



More information about the hotspot-gc-dev mailing list