RFR: 8254335: logging/logStream.hpp includes memory/resourceArea.hpp but doesn't need it

Daniel D.Daugherty dcubed at openjdk.java.net
Sat Oct 10 03:19:15 UTC 2020


While cleaning up the logging in Erik's new code for:

    JDK-8253064 monitor list simplifications and getting rid of TSM

I noticed that logging/logStream.hpp includes memory/resourceArea.hpp
but doesn't need it.

That include was added to logging/logStream.hpp by:

    JDK-8153659 Create a CHeap backed LogStream class

but logging/logStream.hpp has since evolved to no longer
use ResourceMarks in the header file. Looks like that work
was done via:

    JDK-8181917: Refactor UL LogStreams to avoid using resource area

Of course, removing the include of memory/resourceArea.hpp reveals
other code that uses ResourceMark(s), but never bothered to include
memory/resourceArea.hpp.

-------------

Commit messages:
 - Update copyright years as needed.
 - JDK-8254335: logging/logStream.hpp includes memory/resourceArea.hpp but doesn't need it

Changes: https://git.openjdk.java.net/jdk/pull/584/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=584&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8254335
  Stats: 16 lines in 11 files changed: 10 ins; 1 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/584.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/584/head:pull/584

PR: https://git.openjdk.java.net/jdk/pull/584



More information about the hotspot-gc-dev mailing list