RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v14]

Thomas Stuefe stuefe at openjdk.java.net
Mon Oct 12 13:13:27 UTC 2020


On Mon, 12 Oct 2020 13:01:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add ASCII art to better describe Metachunk relationship to their payload
>
> src/hotspot/share/memory/metaspace/metachunk.hpp line 166:
> 
>> 164: // |  chunk  |  chunk  |      chunk        |
>> 165: // +---------+---------+-------------------+
>> 166: //
> 
> Do you have this same picture twice?  Other than that, thank you for the ascii art.  I think it'll help understand all
> of this code.

Thought you like it :) The first picture describes the general division between headers and (possibly distant) chunks,
the latter how the _prev_in_vs/_next_in_vs chains headers for adjacent chunks together. The latter is a result of some
confusion Richard and I had during our last review round.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336



More information about the hotspot-gc-dev mailing list