RFR: 8254674: G1: Improve root location reference to dead obj verification message

Leo Korinth lkorinth at openjdk.java.net
Thu Oct 15 10:29:10 UTC 2020


On Tue, 13 Oct 2020 11:15:36 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this tiny change that augments the
> 
> Root location 0x00007fc6497f5070 points to dead obj 0x00000000e0200000
> 
> message with region information as G1 does for other references:
> 
> points to dead obj 0x00000000e0300000 in region 3:(HS)[0x00000000e0300000,0x00000000e0400000,0x00000000e0400000]
> 
> I.e. resulting in something like
> 
> Root location 0x00007fe388b7f070 points to dead obj 0x00000000e0200000 in region
> 2:(HS)[0x00000000e0200000,0x00000000e0300000,0x00000000e0300000]
> This saves a few seconds looking up the region for the failing address during debugging..
> 
> Testing: local compilation, local verification on failing case
> 
> Thanks,
>   Thomas

Looks good to me.

-------------

Marked as reviewed by lkorinth (Committer).

PR: https://git.openjdk.java.net/jdk/pull/631



More information about the hotspot-gc-dev mailing list