Integrated: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
Thomas Schatzl
tschatzl at openjdk.java.net
Fri Oct 16 09:22:13 UTC 2020
On Wed, 14 Oct 2020 12:23:23 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that fixes aborting the concurrent next bitmap clear if aborted?
>
> The problems are that we can enter the clear loop with the marking already aborted, so
> - yielding does not return true any more (marking aborted while joining the STS) and we never abort in the loop if we
> join all conditions together
> - and G1 at least clears the first part(s) of the bitmap as the check is done afterwards
>
> Testing: tier1-5; no more reproducable crashes with other changes (JDK-8253600)
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: 1742c44a
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/1742c44a
Stats: 12 lines in 1 file changed: 8 ins; 4 del; 0 mod
8254695: G1: Next mark bitmap clear not cancelled after marking abort
Reviewed-by: iwalulya, sjohanss
-------------
PR: https://git.openjdk.java.net/jdk/pull/653
More information about the hotspot-gc-dev
mailing list