RFR: 8255131: G1CollectedHeap::is_in() returns wrong result

Stefan Johansson sjohanss at openjdk.java.net
Thu Oct 22 10:23:13 UTC 2020


On Thu, 22 Oct 2020 08:46:06 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this change to exchange the broken G1CollectedHeap::is_in() by G1CollectedHeap::is_in_exact() that has the same performance profile and correct.
> 
> G1CollectedHeap::is_in() returns true for any region ever committed (and crashes for not yet committed regions), while is_in_exact() (almost) did the right thing. Almost because HeapRegionManager::is_available() would assert if the given pointer is outside the heap and it's not guarded by is_in_reserved.
> 
> Test: tier1
> 
> Thanks,
>   Thomas

Looks good!

-------------

Marked as reviewed by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/799



More information about the hotspot-gc-dev mailing list