Integrated: 8255131: G1CollectedHeap::is_in() returns wrong result

Thomas Schatzl tschatzl at openjdk.java.net
Fri Oct 23 08:25:38 UTC 2020


On Thu, 22 Oct 2020 08:46:06 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this change to exchange the broken G1CollectedHeap::is_in() by G1CollectedHeap::is_in_exact() that has the same performance profile and correct.
> 
> G1CollectedHeap::is_in() returns true for any region ever committed (and crashes for not yet committed regions), while is_in_exact() (almost) did the right thing. Almost because HeapRegionManager::is_available() would assert if the given pointer is outside the heap and it's not guarded by is_in_reserved.
> 
> Test: tier1
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: c5204696
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c5204696
Stats:     29 lines in 5 files changed: 0 ins; 25 del; 4 mod

8255131: G1CollectedHeap::is_in() returns wrong result

Reviewed-by: sjohanss, kbarrett, ayang

-------------

PR: https://git.openjdk.java.net/jdk/pull/799



More information about the hotspot-gc-dev mailing list